Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.

python3Packages.fastapi: remove broken patch #17

Closed
wants to merge 1 commit into from
Closed

python3Packages.fastapi: remove broken patch #17

wants to merge 1 commit into from

Conversation

zopieux
Copy link

@zopieux zopieux commented Feb 18, 2020

Motivation for this change

Upstream modified the revision pointed by the current tag (0.45.0) which broke the inline patch.

Pinning is not necessary anymore since upstream now specifies "pydantic >=0.32.2,<2.0.0": https://github.com/tiangolo/fastapi/blob/0.45.0/pyproject.toml#L36

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zopieux
python3Packages.fastapi: remove broken patch
220d080 
Upstream modified the revision pointed by the current tag (0.45.0) which broke the inline patch.

Pinning is not necessary anymore since upstream now specifies `"pydantic >=0.32.2,<2.0.0"`: https://github.com/tiangolo/fastapi/blob/0.45.0/pyproject.toml#L36
@zopieux zopieux closed this Feb 18, 2020
@zopieux zopieux deleted the patch-1 branch February 18, 2020 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@zopieux