Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: remove 0.25 and 0.26 #80473

Merged
merged 1 commit into from Feb 19, 2020
Merged

crystal: remove 0.25 and 0.26 #80473

merged 1 commit into from Feb 19, 2020

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Feb 18, 2020 •
edited

Motivation for this change

Crystal versions 0.25 and 0.26 are failing to build. Given that it's very unlikely anybody is still using versions from 2018, I advocate for their removal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ZHF: #80379

@peterhoeg
Copy link
Member

👍 from here.

@disassembler disassembler merged commit 9412db1 into NixOS:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @peterhoeg @disassembler