Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

milkytracker: set cmake sdl variable to fix build #80414

Merged
merged 1 commit into from Feb 18, 2020
Merged

milkytracker: set cmake sdl variable to fix build #80414

merged 1 commit into from Feb 18, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Feb 18, 2020

Motivation for this change

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build milkytracker

jonringer
jonringer approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
gui opens fine

[2 built, 3 copied (12.9 MiB), 3.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80414
1 package built:
milkytracker

@jonringer jonringer merged commit eb2ab18 into NixOS:master Feb 18, 2020
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 18, 2020
@jonringer
Copy link
Contributor

please open PR to release-20.03

@fgaz fgaz mentioned this pull request Feb 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @jonringer