Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] tor-browser-bundle-bin: 9.0.4 -> 9.0.5 (backport) #80383

Merged
merged 1 commit into from Feb 19, 2020
Merged

[19.09] tor-browser-bundle-bin: 9.0.4 -> 9.0.5 (backport) #80383

merged 1 commit into from Feb 19, 2020

Conversation

hax404
Copy link
Contributor

@hax404 hax404 commented Feb 17, 2020

Motivation for this change

backport of #80210

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (32 and 64bit)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

security was mentioned https://blog.torproject.org/new-release-tor-browser-905

@worldofpeace
Copy link
Contributor

@hax404 You need to cherry-pick with -x. https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes

@hax404 hax404 force-pushed the 19.09_tor-browser-bundle-bin branch from 3423232 to c4a54b6 Compare February 18, 2020 09:56
@hax404
Copy link
Contributor Author

hax404 commented Feb 18, 2020

done

@worldofpeace worldofpeace merged commit c4ab092 into NixOS:release-19.09 Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hax404 @worldofpeace