Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatpak: 1.6.1 -> 1.6.2 #80386

Merged
merged 1 commit into from Feb 18, 2020
Merged

flatpak: 1.6.1 -> 1.6.2 #80386

merged 1 commit into from Feb 18, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 17, 2020

Motivation for this change

https://github.com/flatpak/flatpak/releases/tag/1.6.2

Due to a combination of some behaviour in flatpak and recent versions of ostree we at some
point lost the use of deltas for the initial install case, instead always falling back
to a full ostree operation which is a lot less efficient for pulls with many small files
like a runtime. This caused some very slow installs from e.g. flathub, so I recommend
everyone update to this version to get better install performance.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 17, 2020
@worldofpeace worldofpeace added this to the 20.03 milestone Feb 17, 2020
@worldofpeace
Copy link
Contributor

We for sure should backport this to 20.03. Thanks @zowoq

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build flatpak

@ofborg ofborg bot requested a review from jtojnar February 17, 2020 23:59
@jtojnar
Copy link
Contributor

jtojnar commented Feb 18, 2020

Ooh, I thought I have already updated it but never pushed the branch 🤷‍♀️

Looks good to me, though I did not test it. And it appears I actually broke the installed tests last time.

@jtojnar jtojnar merged commit 8fa73be into NixOS:master Feb 18, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Feb 18, 2020

Thanks.

@worldofpeace
Copy link
Contributor

backported to 20.03 in e6febf8

@worldofpeace worldofpeace added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 18, 2020
@zowoq zowoq deleted the flatpak branch February 18, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @worldofpeace @jtojnar