Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-combined: readd keymap tests (again) #80387

Merged
merged 1 commit into from Feb 22, 2020
Merged

release-combined: readd keymap tests (again) #80387

merged 1 commit into from Feb 22, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

These got removed, then readded, and then removed again 馃ぃ

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 17, 2020
@vcunat
Copy link
Member

vcunat commented Feb 18, 2020 •
edited

Oh, I didn't check that Eelco removed them. On 20.03 I thought everything is OK when this kind of commit applied cleanly :-)

@vcunat vcunat merged commit e01412b into NixOS:master Feb 22, 2020
@worldofpeace worldofpeace deleted the add-keymap-again branch February 22, 2020 22:10
@worldofpeace worldofpeace mentioned this pull request Feb 22, 2020
Merged
10 tasks
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @vcunat