symlinkJoin: fix "bash: Argument list too long" error (release-19.09) #80420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `paths` argument is too big `symlinkJoin` will fail with: ``` while setting up the build environment: executing '/nix/store/rm1hz1lybxangc8sdl7xvzs5dcvigvf7-bash-4.4-p23/bin/bash': Argument list too long ``` This is fixed by passing `paths` as a file instead of as an environment variable. (cherry picked from commit 4e0a6bc)
basvandijk
changed the title
|
The NixOS @GrahamcOfBorg test boot |
| in runCommand name args | ||
| '' | ||
| mkdir -p $out | ||
| for i in $paths; do | ||
| for i in $(cat $pathsPath); do |
There was a problem hiding this comment.
I think this could overflow as well if you have tons of paths.
There was a problem hiding this comment.
Better would be:
Suggested change
| for i in $(cat $pathsPath); do | |
| cat $pathsPath | while read i; do |
There was a problem hiding this comment.
Oh I now see that this is already in master. I guess it makes sense for now.
|
I expect 19.09 isn't worth the effort anymore. |
|
Appears similar to #97475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Cherry-pick of #80348 on
release-19.09.When the
pathsargument is too bigsymlinkJoinwill fail with:Things done
Cherry picked from commit 4e0a6bc which passes
pathsas a file instead of as an environment variable.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)