Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MozPhab: init at 0.1.74 #79012

Closed
wants to merge 1 commit into from
Closed

MozPhab: init at 0.1.74 #79012

wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Feb 1, 2020 •
edited

Motivation for this change

MozPhab is the recommended tool for submitting patches to Mozilla Firefox.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof changed the title ###### Motivation for this change MozPhab: init at 0.1.74 Feb 1, 2020
sikmir
sikmir reviewed Feb 2, 2020
View reviewed changes
maintainers/maintainer-list.nix Outdated
@@ -5777,6 +5777,11 @@
fingerprint = "7573 56D7 79BB B888 773E 415E 736C CDF9 EF51 BD97";
}];
};
raboof = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding yourself as a maintainer is preferred to be a separate commit.
Something like, maintainers: add raboof. Then apply the MozPhab commit.

@raboof raboof force-pushed the init-moz-phab branch 2 times, most recently from 79393f4 to cedec2d Compare February 2, 2020 12:37
@raboof
Copy link
Member Author

raboof commented Feb 2, 2020

@sikmir thanks for the review - updated accordingly!

@raboof raboof requested a review from sikmir March 1, 2020 15:54
@grahamc
Copy link
Member

grahamc commented Apr 6, 2020

@GrahamcOfBorg eval

@raboof
Copy link
Member Author

raboof commented Apr 7, 2020

abandoning this for now until I want to do a mozilla contribution again :)

@raboof raboof closed this Apr 7, 2020
@kvark
Copy link
Contributor

kvark commented Nov 17, 2021

I'm interested to bring this back to life

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raboof @grahamc @kvark @sikmir