Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Symbol not found _dyld_enumerate_tlv #78979

Closed
wants to merge 1 commit into from
Closed

Fix Symbol not found _dyld_enumerate_tlv #78979

wants to merge 1 commit into from

Conversation

lionello
Copy link
Contributor

@lionello lionello commented Feb 1, 2020

Motivation for this change

Port of dlang/druntime#2666 to LDC 0.17.6 which is used to bootstrap LDC and DMD.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lionello lionello requested a review from globin February 1, 2020 03:04
@lionello
Copy link
Contributor Author

lionello commented Feb 1, 2020

Patch will not be needed if this fix gets merged upstream by ldc-developers/druntime#172

@lionello lionello mentioned this pull request Feb 1, 2020
Closed
10 tasks
@ThomasMader
Copy link
Contributor

I guess this can be closed now because of #85488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lionello @ThomasMader @worldofpeace