Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: 12.6.4 -> 12.7.4 #78952

Merged
merged 4 commits into from Feb 1, 2020
Merged

gitlab: 12.6.4 -> 12.7.4 #78952

merged 4 commits into from Feb 1, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 31, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from krav, talyz and bgamari January 31, 2020 11:35
@flokli
Copy link
Contributor Author

flokli commented Jan 31, 2020

@GrahamcOfBorg test gitlab

@Ma27 Ma27 merged commit 8b92ddf into NixOS:master Feb 1, 2020
@Ma27
Copy link
Member

Ma27 commented Feb 1, 2020

Thanks! Backported as 100bf01, 4cc414d, 2fa8395 and 11edc69.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 1, 2020
@flokli
Copy link
Contributor Author

flokli commented Feb 1, 2020 via email

@Ma27
Copy link
Member

Ma27 commented Feb 1, 2020

Not yet. So feel free to file a PR :)

@flokli flokli deleted the gitlab-12.7.4 branch February 1, 2020 16:04
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants