-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/ldap: remove redundant configuration options #78960
Conversation
@GrahamcOfBorg test ldap |
I guess the |
Uff, it used to work… Did you verify things still work with a local setup? I'd rather see this being tested somehow, if we can't get the tests to work right now… |
I deployed this change to a nixops machine and was able to access the machine via I'll run some more tests, including running a command via |
Thanks!
|
With this change I have confirmed that for an account authenticated via
After reading through source code to better understand where these errors might be coming from, combined with the mentioned testing I believe this PR is ready for a merge. |
Alright. Thanks :-) |
nixos/ldap: remove redundant configuration options (cherry picked from commit d4a951f)
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)