Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drone-cli: 1.2.0 -> 1.2.1 #78959

Merged
merged 1 commit into from Feb 1, 2020
Merged

drone-cli: 1.2.0 -> 1.2.1 #78959

merged 1 commit into from Feb 1, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Jan 31, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Jan 31, 2020

@GrahamcOfBorg build drone-cli

@ofborg ofborg bot requested review from bricewge and kalbasit January 31, 2020 14:57
bricewge
bricewge approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@bricewge bricewge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marsam marsam merged commit 7ec40ec into NixOS:master Feb 1, 2020
@marsam
Copy link
Contributor

marsam commented Feb 1, 2020

Thanks!

anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@marsam @anna328p
Merge pull request NixOS#78959 from kampka/drone-cli
4dc6c62 
drone-cli: 1.2.0 -> 1.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricewge bricewge bricewge approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @marsam @bricewge