Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_13: 1.13.6 -> 1.13.7, go_1_12: 1.12.15 -> 1.12.16 #78991

Merged
merged 2 commits into from Feb 3, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 1, 2020

Motivation for this change

Go 1.13.7 and 1.12.16 (released 2020/01/28) includes two security fixes to the crypto/x509 package

Go itself works fine, but it seems like there are a few packages failing unrelated to the change, currently investigating.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@kalbasit
Copy link
Member

kalbasit commented Feb 1, 2020

@Frostman what are the failing packages?

@Frostman
Copy link
Member Author

Frostman commented Feb 1, 2020

@kalbasit aria2p and editorconfig-checker are failing:

hash mismatch in fixed-output derivation '/nix/store/6ghdnnzr7w8ah9p6pym8mik67bp580jy-editorconfig-checker-2.0.2-go-modules':
  wanted: sha256:09b1v9gyh6827yqlfxxxq3lcqhd5snn3n7gdlbjmga3wyp2x4g2r
  got:    sha256:1iiv12ginb3ky739z7v8wf4z5lv24gmghbybs3lzay0kqn449n4x
cannot build derivation '/nix/store/dhickjqkym3hgr7ispji7yi7argwbnpj-editorconfig-checker-2.0.2.drv': 1 dependencies couldn't be built
builder for '/nix/store/k2x86lq0csx8gvbxd9yqzfl9x60k55d8-python3.8-aria2p-0.7.0.drv' failed with exit code 2; last 10 log lines:
    File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
    File "<frozen importlib._bootstrap>", line 991, in _find_and_load
    File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
    File "<frozen importlib._bootstrap>", line 991, in _find_and_load
    File "<frozen importlib._bootstrap>", line 973, in _find_and_load_unlocked
  ModuleNotFoundError: No module named 'poetry'

For editorconfig-checker, I'm not sure how modules hash could change...

And python3.7-python-hglib-2.6.1 is stuck on running install tests if I'm reading it correctly:

[1/47/50 built (2 failed), 79 copied (511.0/511.4 MiB), 202.0 MiB DL] building python3.7-python-hglib-2.6.1 (installCheckPhase): running install tests

(not changing for 30+ minutes)

@FRidh FRidh added this to WIP in Staging via automation Feb 2, 2020
@Frostman
Copy link
Member Author

Frostman commented Feb 3, 2020

I did another rebuild with the current master and there are the same issues.

@kalbasit I'm very new for NixOS, so, would appreciate it if you can share some ideas on the next steps or even if it's a blocker or not. thanks!

@kalbasit
Copy link
Member

kalbasit commented Feb 3, 2020

@GrahamcOfBorg build go_1_12 go_1_13 pet jx

@ofborg ofborg bot requested a review from kalbasit February 3, 2020 19:54
@kalbasit kalbasit changed the title (WIP) go: 1.13.6 -> 1.13.7, go_1_12: 1.12.15 -> 1.12.16 go_1_13: 1.13.6 -> 1.13.7, go_1_12: 1.12.15 -> 1.12.16 Feb 3, 2020
Staging automation moved this from WIP to Ready Feb 3, 2020
@kalbasit kalbasit merged commit 45cbae8 into NixOS:master Feb 3, 2020
Staging automation moved this from Ready to Done Feb 3, 2020
@Frostman Frostman deleted the go-bump branch February 3, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants