Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.maxminddb: 1.5.0 -> 1.6.0 #78962

Merged
merged 1 commit into from Feb 23, 2020
Merged

phpPackages.maxminddb: 1.5.0 -> 1.6.0 #78962

merged 1 commit into from Feb 23, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 31, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested a review from etu as a code owner January 31, 2020 16:12
@ofborg ofborg bot requested a review from dasJ January 31, 2020 16:22
@aanderse
Copy link
Member

aanderse commented Feb 1, 2020

@dasJ I still haven't started using this yet... are you able to validate?

@dasJ
Copy link
Member

dasJ commented Feb 1, 2020

Oof @ajs124 have you tested it?

@ajs124
Copy link
Member Author

ajs124 commented Feb 17, 2020

Yes, I have. Feel free to check our matomo instance @dasJ

dasJ
dasJ approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@aanderse
Copy link
Member

Thanks everyone 🎉

@aanderse aanderse merged commit 1462c33 into NixOS:master Feb 23, 2020
@ajs124 ajs124 deleted the upd/php-maxminddb branch February 23, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
9.needs: reporter feedback 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @aanderse @dasJ @FRidh