New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
real_time_config_quick_scan: init at unstable-2020-01-16 #78998
Conversation
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
Thanks! |
meta = with stdenv.lib; { | ||
description = "Linux configuration checker for systems to be used for real-time audio"; | ||
homepage = "https://github.com/raboof/realtimeconfigquickscan"; | ||
license = licenses.gpl2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this should be gpl2Plus
:
|
||
dontBuild = true; | ||
|
||
installPhase = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When overriding installPhase
, you should also provide runHook preInstall
and runHook postInstall
.
mkdir -p $out/share/doc | ||
# Install Script Files: | ||
# *.pm files | ||
for i in *.pm; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be also nice if you asked upstream to add an installation script so that distros do not need to write code like this:
It could be a simple makefile or maybe one of the things suggested in https://perlmaven.com/makefile-pl-of-module-install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing most the text for the issue!
install -Dm 755 "$i" "$out/share/$i" | ||
done | ||
# Install doc files: | ||
install -D COPYING "$out/share/doc/COPYING" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can create a conflict with another package installing the same file. It should go to $out/share/doc/$name
or something.
# Install Executable scripts: | ||
install -Dm 755 realTimeConfigQuickScan.pl "$out/bin/realTimeConfigQuickScan" | ||
install -Dm 755 QuickScan.pl "$out/bin/QuickScan" | ||
wrapProgram $out/bin/realTimeConfigQuickScan \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrappers would typically go to fixupPhase
, for example using postFixup
.
also resolve suggestions from NixOS#78998
also resolve suggestions from #78998
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)