Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager_dmenu: 1.1 -> 1.5.0 #78999

Merged
merged 1 commit into from Jun 25, 2020
Merged

networkmanager_dmenu: 1.1 -> 1.5.0 #78999

merged 1 commit into from Jun 25, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Feb 1, 2020 •
edited

Motivation for this change

Update to the latest release.
The current nixpkgs version is ancient.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jensbin February 1, 2020 09:38
@worldofpeace
Copy link
Contributor

Release https://github.com/firecat53/networkmanager-dmenu/releases/tag/1.5.0

@magnetophon magnetophon changed the title networkmanager_dmenu: 1.1 -> unstable-2020-01-26 networkmanager_dmenu: 1.1 -> 1.5.0 Feb 2, 2020
@magnetophon
Copy link
Member Author

Done.

@magnetophon
Copy link
Member Author

I totally missed the conflict. Fixed now!

@Pacman99
Copy link
Contributor

The update/pr builds and works perfectly for me. It adds significant improvements to the program. It would be really great if it could be merged

@magnetophon
Copy link
Member Author

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 20, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 20, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@magnetophon
Copy link
Member Author

/status needs_merge

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 20, 2020

Sorry, you cannot set your own PR to needs_merge. Please wait for an external review. You may also actively search out a reviewer by pinging relevant people (look at the history of the files you're changing) or posting on discourse or IRC.

@magnetophon
Copy link
Member Author

/status needs_review

@timokau
Copy link
Member

timokau commented Jun 25, 2020

Thanks!
/status needs_merge

@marvin-mk2 marvin-mk2 bot requested a review from timokau June 25, 2020 18:49
@timokau timokau merged commit 2957459 into NixOS:master Jun 25, 2020
@timokau
Copy link
Member

timokau commented Jun 25, 2020 •
edited

(And sorry this has been sitting idle for way too long)

@magnetophon
Copy link
Member Author

magnetophon commented Jun 25, 2020 •
edited

@timokau No need to apologize, there's a lot more PR's than maintainers at the moment.

So thank you!

@magnetophon magnetophon deleted the networkmanager_dmenu branch June 25, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jensbin jensbin Awaiting requested review from jensbin

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@magnetophon @worldofpeace @Pacman99 @timokau @alyssais