Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/httpd: add http2 option #79046

Merged
merged 1 commit into from Feb 6, 2020
Merged

nixos/httpd: add http2 option #79046

merged 1 commit into from Feb 6, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Feb 1, 2020 •
edited

Motivation for this change

Add http2 support in the httpd module. Given the default multiProcessingModule is prefork it probably doesn't make sense to enable it by default though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse marked this pull request as ready for review February 2, 2020 01:59
@aanderse
Copy link
Member Author

aanderse commented Feb 6, 2020

@GrahamcOfBorg test mediawiki

@aanderse aanderse merged commit f87440f into NixOS:master Feb 6, 2020
@aanderse aanderse deleted the http2 branch February 6, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aanderse