Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpPackages.sqlsrv & pdo_sqlsrv: 5.6.1 -> 5.8.0 #78975

Merged
merged 2 commits into from Feb 1, 2020
Merged

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Feb 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Feb 1, 2020

@GrahamcOfBorg build php72Packages.pdo_sqlsrv php72Packages.sqlsrv
@GrahamcOfBorg build php74Packages.pdo_sqlsrv php74Packages.sqlsrv

@aanderse
Copy link
Member Author

aanderse commented Feb 1, 2020

Tested basic connectivity with pdo_sqlsrv on php72, php73, and php74.

@aanderse aanderse merged commit d5bf8b2 into NixOS:master Feb 1, 2020
@aanderse aanderse deleted the sqlsrv branch February 1, 2020 13:05
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
phpPackages.sqlsrv & pdo_sqlsrv: 5.6.1 -> 5.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant