Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ytop: init at 0.4.0 #79021

Merged
merged 1 commit into from Feb 2, 2020
Merged

ytop: init at 0.4.0 #79021

merged 1 commit into from Feb 2, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Feb 1, 2020 •
edited

Motivation for this change

From cjbassi/gotop README:

NO LONGER MAINTAINED. Future development has moved to ytop, a Rust port of gotop.

cjbassi/ytop - a TUI system monitor written in Rust.

cc @magnetophon, @marsam

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh ./result
/nix/store/cf0495whapdjgdafdj6mw9spsycygal1-ytop-0.4.0	 29.4M

@magnetophon
Copy link
Member

lgtm!

@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 2, 2020 •
edited

@sikmir Can we remove gotop and add migration instructions in aliases.nix?

Edit: it doesn't seem abandoned though.

@magnetophon
Copy link
Member

@worldofpeace What do you mean? The readme is pretty clear, isn't it?

@sikmir
Copy link
Member Author

sikmir commented Feb 2, 2020

@sikmir Can we remove gotop and add migration instructions in aliases.nix?

There is no parity in functionality between ytop and gotop yet (e.g. mouse usage isn't implemented in ytop yet). So I would say we can remove gotop at some point in the future (maybe when ytop 1.x.x will be out), but not now.

@marsam marsam merged commit c7458ab into NixOS:master Feb 2, 2020
@marsam
Copy link
Contributor

marsam commented Feb 2, 2020

Thank you @sikmir. I agree we can remove gotop later.

@sikmir sikmir deleted the ytop branch February 2, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sikmir @magnetophon @worldofpeace @marsam