Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blackmagic: v1.6.1-317-gc9c8b08 -> v1.6.1-409-g7a595ea (add new targets) #79026

Merged
merged 2 commits into from Mar 2, 2020
Merged

blackmagic: v1.6.1-317-gc9c8b08 -> v1.6.1-409-g7a595ea (add new targets) #79026

merged 2 commits into from Mar 2, 2020

Conversation

sorki
Copy link
Member

@sorki sorki commented Feb 1, 2020

Motivation for this change

Update to more recent version. Also exposes hosted targets which can be run on host system instead of microcontroller (requires libusb and pkg-config).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from emilazy and pjones February 1, 2020 18:26
emilazy
emilazy approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for not getting around to this myself; I was hoping there'd be a tagged upstream release sooner.

@GrahamcOfBorg build blackmagic

@mmahut
Copy link
Member

mmahut commented Feb 4, 2020

@GrahamcOfBorg build blackmagic

@emilazy
Copy link
Member

emilazy commented Feb 5, 2020

Looks like stdenv is passing down CFLAGS it shouldn't to arm-embedded-gcc on Darwin. If you're not sure how to fix that, probably best just to mark it as only building on Linux for now?

@mmilata
Copy link
Member

mmilata commented Feb 19, 2020

fyi ZHF: #80379

@emilazy
Copy link
Member

emilazy commented Feb 19, 2020

Hopefully the bump will fix the error, but whoever merges should make sure to switch platforms to Linux-only so they don't introduce a new one in the process ^^;

@sorki
Copy link
Member Author

sorki commented Feb 19, 2020

I'll take a look and update to more recent version as well.

@sorki
blackmagic: v1.6.1-317-gc9c8b08 -> v1.6.1-409-g7a595ea
bb73acd
@sorki
blackmagic: add libusb, pkgconfig. expose pc-* (hosted) targets
87057d9 
Add myself to maintainers and change meta.platforms to platforms.linux
due to build failures on Darwin.
@sorki
Copy link
Member Author

sorki commented Feb 20, 2020

Bumped version, now uses platforms.linux instead of platforms.unix. I've also added myself to maintainers.

@ofborg ofborg bot requested a review from emilazy February 20, 2020 10:13
@sorki sorki changed the title blackmagic: v1.6.1-317-gc9c8b08 -> v1.6.1-404-gc3a3f77 (add new targets) blackmagic: v1.6.1-317-gc9c8b08 -> v1.6.1-409-g7a595ea (add new targets) Feb 20, 2020
@mmahut
Copy link
Member

mmahut commented Feb 25, 2020

@GrahamcOfBorg build blackmagic

vcunat added a commit that referenced this pull request Mar 2, 2020
@vcunat
Merge #79026: blackmagic: v1.6.1-317-gc9c8b08 -> v1.6.1-409-g7a595ea
89528af 
(cherry picked from commit 855f020)
It didn't build before this bump.
@vcunat vcunat merged commit 855f020 into NixOS:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@emilazy emilazy emilazy approved these changes

@pjones pjones Awaiting requested review from pjones

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sorki @mmahut @emilazy @mmilata @vcunat