Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability? Can we warn if a Statement is never assigned to a domain? #303

Closed
nmigen-issue-migration opened this issue Jan 12, 2020 · 1 comment
Closed

Usability? Can we warn if a Statement is never assigned to a domain? #303

nmigen-issue-migration opened this issue Jan 12, 2020 · 1 comment
Labels
improvement
Milestone
0.2

Comments

@nmigen-issue-migration
Copy link

Issue by RobertBaruch
Sunday Jan 12, 2020 at 22:23 GMT
Originally opened as m-labs/nmigen#303

All too often I've been charging ahead writing formal assertions, and I forget to put one in a domain, writing:

Assert(...)

instead of

m.d.comb += Assert(...)

This sort of thing is silently ignored, so I go on merrily believing my formal verification worked, when in fact I simply never verified certain assertions.

If anything, this is especially nasty for Asserts, Assumes, and Covers that do not get added to a domain. Can there at least be a warning there? Is it possible?
@nmigen-issue-migration
Copy link
Author

Comment by whitequark
Sunday Jan 12, 2020 at 22:24 GMT

Absolutely possible, and we should do this. We already do this for Elaboratables.

@nmigen-issue-migration nmigen-issue-migration added this to the 0.2 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Milestone
0.2
Development

No branches or pull requests
1 participant
@nmigen-issue-migration