Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: amaranth-lang/amaranth
base: 687d3a3df74b
Choose a base ref
...
head repository: amaranth-lang/amaranth
compare: afece150016e
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Feb 1, 2020

  1. _unused: extract must-use logic from hdl.ir.

    @whitequark
    whitequark committed Feb 1, 2020
    Copy the full SHA
    9fb4a4f View commit details
    Browse the repository at this point in the history

  2. hdl.ast: warn on unused property statements (Assert, Assume, etc). 

    A property statement that is created but not added to a module is
virtually always a serious bug, since it can make formal verification
pass when it should not. Therefore, add a warning to it, similar to
UnusedElaboratable.

Doing this to all statements is possible, but many temporary ones are
created internally by nMigen, and the extensive changes required to
remove false positives are likely not worth the true positives.
We can revisit this in the future.

Fixes #303.
    @whitequark
    whitequark committed Feb 1, 2020
    Copy the full SHA
    afece15 View commit details
    Browse the repository at this point in the history