Issue by AsuMagic
Thursday Dec 26, 2019 at 18:04 GMT
Originally opened as m-labs/nmigen#286

Consider the following migen code:

class ORGate(Module):
	def __init__(self):
		self.a = Signal()
		self.b = Signal()
		self.x = Signal()

		self.comb += self.x.eq(self.a | self.b)

While this is not the valid way to implement this in nmigen, if you try to use this code as-is in nmigen, the error is misleading:

  File "/usr/lib/python3.8/site-packages/nmigen/hdl/dsl.py", line 75, in __getattr__
    raise AttributeError("'{}' object has no attribute '{}'; did you mean 'd.{}'?"
AttributeError: 'ORGate' object has no attribute 'comb'; did you mean 'd.comb'?

If my understanding is right, the direct alternative to the above code in nmigen is to inherit from Elaboratable and use the elaborate() mechanism.
In that case, the error check should hint at this accordingly, instead of incorrectly hinting to use d.comb.