Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confluence: Add support for MySQL driver #79029

Merged
merged 1 commit into from Feb 2, 2020
Merged

confluence: Add support for MySQL driver #79029

merged 1 commit into from Feb 2, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Feb 1, 2020

If Confluence should be connected to a MySQL database, the JDBC driver
is required.
Also switch to stdenvNoCC, because we don't really use cc.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
confluence: Add support for MySQL driver
7dadbc7 
If Confluence should be connected to a MySQL database, the JDBC driver
is required.
Also switch to stdenvNoCC, because we don't really use cc.
@dasJ
Copy link
Member Author

dasJ commented Feb 1, 2020

@GrahamcOfBorg build atlassian-confluence

@ofborg ofborg bot requested review from globin, WilliButz and fpletz February 1, 2020 18:51
fpletz
fpletz approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 But I would not recommend running Confluence with MySQL. Some years ago, we were forced to migrate from MySQL to PostgreSQL (which we wanted to do anyway) because an upgrade failed and we couldn't even import the backup XML into a clean DB with this new Confluence version. We then tried importing the XML with PostgreSQL, which funnily enough worked flawlessly. :)

@fpletz fpletz merged commit 8b8b6b2 into NixOS:master Feb 2, 2020
@ajs124 ajs124 deleted the confluence-mysql branch November 15, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@ajs124 ajs124 ajs124 approved these changes

@globin globin Awaiting requested review from globin

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @fpletz @ajs124