Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k9s: 0.9.3 -> 0.13.6 #79031

Closed
wants to merge 1 commit into from
Closed

k9s: 0.9.3 -> 0.13.6 #79031

wants to merge 1 commit into from

Conversation

rycee
Copy link
Member

@rycee rycee commented Feb 1, 2020

Motivation for this change

Bump k9s.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Gonzih and kalbasit February 1, 2020 19:15
Gonzih
Gonzih approved these changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@Gonzih Gonzih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested via nix-review.

rycee added a commit that referenced this pull request Feb 1, 2020
@rycee
k9s: 0.9.3 -> 0.13.6
a6e9b59 
PR #79031
@rycee
Copy link
Member Author

rycee commented Feb 1, 2020

Thanks for the review! Rebased to master in a6e9b59.

@rycee rycee closed this Feb 1, 2020
@rycee rycee deleted the bump/k9s branch February 1, 2020 23:20
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@rycee @anna328p
k9s: 0.9.3 -> 0.13.6
2b06757 
PR NixOS#79031
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 2, 2020
@rycee @dtzWill
k9s: 0.9.3 -> 0.13.6
0dd010a 
PR NixOS#79031

(cherry picked from commit a6e9b59)
jpgu-epam pushed a commit to jpgu-epam/nixpkgs that referenced this pull request Feb 4, 2020
@rycee @jpgu-epam
k9s: 0.9.3 -> 0.13.6
5ebd1eb 
PR NixOS#79031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gonzih Gonzih Gonzih approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rycee @Gonzih