Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmd: 2.085.1 -> 2.090.0 #78995

Closed
wants to merge 2 commits into from
Closed

dmd: 2.085.1 -> 2.090.0 #78995

wants to merge 2 commits into from

Conversation

lionello
Copy link
Contributor

@lionello lionello commented Feb 1, 2020 •
edited

Motivation for this change

Update to latest DMD https://github.com/dlang/dmd/releases/tag/v2.090.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lionello
Copy link
Contributor Author

lionello commented Feb 1, 2020

Ping @ThomasMader who had done similar updates before.

@lionello
Copy link
Contributor Author

lionello commented Feb 1, 2020

Note: this requires #78979 for building from source on macOS 10.15 Catalina.

@ThomasMader
Copy link
Contributor

Thanks a lot.

My plan was to get rid of the bootstrapping version of ldc at some point and just fetch and patchelf the latest ldc binary to bootstrap the build.
AFAIK there are already features which can not be supported if ldc was build with the bootstrap version and at some point they will not provide any updates to it anymore, so it will stop working.

@lionello
Copy link
Contributor Author

lionello commented Feb 1, 2020

My plan was to get rid of the bootstrapping version of ldc at some point and just fetch and patchelf the latest ldc binary to bootstrap the build.
AFAIK there are already features which can not be supported if ldc was build with the bootstrap version and at some point they will not provide any updates to it anymore, so it will stop working.

We could set it up such that you provide a DMD into the dmd and ldc derivations. That could either be a (new derivation) ldc-0.17 or a binary from a fixed output derivation.

veprbl
veprbl reviewed Apr 18, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to cause a regression for Literate on darwin and breaks dmd on NixOS

nixpkgs-review on x86_64-linux (NixOS)

7 package failed to build:
Literate dmd dtools dub gtkd onedrive tilix

nixpkgs-review on x86_64-darwin

1 package marked as broken and skipped:
gtkd

1 package failed to build:
Literate

3 package built:
dmd dtools dub

@veprbl
Copy link
Member

veprbl commented Apr 18, 2020

@GrahamcOfBorg build dmd
@GrahamcOfBorg build Literate

@lionello
Copy link
Contributor Author

Yeah I also noticed a failure on my NixOS VM. Debugging.

@lionello
Copy link
Contributor Author

I'll close this one in favor of #82694

@lionello lionello closed this Apr 18, 2020
@lionello lionello deleted the dmd-2.090.0 branch April 18, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lionello @ThomasMader @veprbl