New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highfive: init at 2.2 #78947
highfive: init at 2.2 #78947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, looks good.
bd8839e
to
5588902
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78947
2 package built:
highfive highfive-mpi
@GrahamcOfBorg build highfive highfive-mpi |
arch failures look to be unrelated to this PR |
(triage) ping |
5588902
to
2b8c5ea
Compare
4bb1ce5
to
858831c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
f3eca4b
to
037e329
Compare
Thanks for the comments! |
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@GrahamcOfBorg eval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation for this change
Add the HighFive header-only C++ HDF5 interface.
Supersedes #78915 where I FUBAR-ed the squashing @jonringer had requested. Apologies for the noise and confusion!
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)