nixos/tests/openarena: run real openarena clients #79016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpletz
added
6.topic: nixos
6.topic: testing
The old Quake3 NixOS test was removed in 50ea99c which served as a nice demo to showcase what NixOS tests are capable of. This commit adds the same functionality to run real openarena clients.
fpletz
force-pushed
the
nixos/openarena-test
branch
from
5ba6387
to
9f1c76f
Compare
Ma27
approved these changes
Feb 1, 2020
rnhmjoj
reviewed
Feb 1, 2020
| "journalctl -u openarena.service | grep 'resolve address: dpmaster.deathmask.net'" | ||
| ) | ||
| server.wait_for_unit("openarena") | ||
| server.wait_until_succeeds("ss --numeric --udp --listening | grep -q 27960") |
There was a problem hiding this comment.
Isn't there a wait_for_open_port()?
There was a problem hiding this comment.
Unfortunately this function only checks for TCP ports.
|
@GrahamcOfBorg test openarena |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The old Quake3 NixOS test was removed in 50ea99c which served as a nice demo to showcase what NixOS tests are capable of. This commit adds the same functionality to run real openarena clients.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)