-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ispell: fix hash and drop patches #79025
Conversation
If we're not applying the patches anymore, we should probably also remove them from nixpkgs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @lheckemann comment
89c5349
to
ef31752
Compare
./patches/0023-Exclusive-options.patch | ||
./patches/0024-Check-tempdir-creation.patch | ||
./patches/0025-Languages.patch | ||
./patches/0030-Display-whole-multibyte-character.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these still might make sense when updated from https://salsa.debian.org/debian/ispell/tree/debian/3.4.00-8/debian/patches. Why they did not upstream them even after all these years is beyond me.
Or if this is intended only for the German dictionary we might make it local as originally suggested.
Or maybe we are fine with vanilla ispell, even though some of those patches look like they should definitely be upstreamed.
I'd vote for just landing this, up-to-date vanilla ispell probably is better matching the nixos way of doing things than debian-old ispell. @jtojnar What do you think about merging this as is? |
I would definitely prefer vanilla package but would like still hear from @timor or @bennofs why they included these patches. @GrahamcOfBorg build hunspellDicts.de-de hunspellDicts.de-ch hunspellDicts.de-at |
I cannot comment on these patches, sorry. I merely re-used @bennofs' code (for the sole purpose of building the German hunspell dictionaries). |
I marked this as stale due to inactivity. → More info |
This was added only to build hunspellDicts.de_DE: [1] The patches came from an older PR (taken from Debian): [2] but aren't needed to build the dictionary. [1]: NixOS#36155 [2]: NixOS#3320
ef31752
to
02fe8cb
Compare
Result of 4 packages built:
|
Motivation for this change
#64285 (comment)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)