Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.science.math.scs: 2.0.2 -> 2.1.1 #78896

Merged
merged 1 commit into from Jan 31, 2020
Merged

lib.science.math.scs: 2.0.2 -> 2.1.1 #78896

merged 1 commit into from Jan 31, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Add dependency for upcoming qiskit #78772

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build scs

jonringer
jonringer approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

[3 built, 2 copied (21.6 MiB), 2.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78896
1 package built:
scs

pkgs/development/libraries/science/math/scs/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor Author

Done & force-pushed. Please merge @jonringer
@GrahamcOfBorg build scs

@ofborg ofborg bot requested a review from bhipple January 31, 2020 21:48
@mmahut mmahut merged commit 7b46677 into NixOS:master Jan 31, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@mmahut @anna328p
Merge pull request NixOS#78896 from drewrisinger/dr-pr-lib-scs
c5d6500 
lib.science.math.scs: 2.0.2 -> 2.1.1
@drewrisinger drewrisinger deleted the dr-pr-lib-scs branch February 3, 2020 15:33
@drewrisinger drewrisinger mentioned this pull request Feb 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drewrisinger @bhipple @jonringer @mmahut