Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aerc: 0.3.0 -> unstable-2020-02-01 #79008

Merged
merged 1 commit into from Feb 3, 2020
Merged

aerc: 0.3.0 -> unstable-2020-02-01 #79008

merged 1 commit into from Feb 3, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 1, 2020

Motivation for this change

The current version seems to go panic on some mail boxes.

It's already fixed in master, but there hasn't been a release yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from andir and d-xo February 1, 2020 11:54
@flokli
aerc: 0.3.0 -> unstable-2020-02-01
fe08bff 
The current version seems to go panic on some mail boxes.

It's already fixed in master, but there hasn't been a release yet.
@d-xo
Copy link
Contributor

d-xo commented Feb 2, 2020

  • nixpkgs-review pr 79008 succeeds
  • aerc binary launches and displays my mailbox

LGTM 👍 🐱

@flokli flokli merged commit ca00a3f into NixOS:master Feb 3, 2020
@flokli flokli deleted the bump-aerc branch February 3, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-xo d-xo d-xo approved these changes

@andir andir Awaiting requested review from andir

@kalbasit kalbasit Awaiting requested review from kalbasit

@tadeokondrak tadeokondrak Awaiting requested review from tadeokondrak

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @d-xo