Skip to content

Commit 7d29611

Browse files
committedFeb 1, 2020
Convert sound_play uses in builtin to ephemeral
1 parent c10e188 commit 7d29611

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed
 

Diff for: ‎builtin/game/falling.lua

+3-3
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ core.register_entity(":__builtin:falling_node", {
128128
meta:from_table(self.meta)
129129
end
130130
if def.sounds and def.sounds.place then
131-
core.sound_play(def.sounds.place, {pos = np})
131+
core.sound_play(def.sounds.place, {pos = np}, true)
132132
end
133133
end
134134
self.object:remove()
@@ -154,7 +154,7 @@ local function convert_to_falling_node(pos, node)
154154

155155
local def = core.registered_nodes[node.name]
156156
if def and def.sounds and def.sounds.fall then
157-
core.sound_play(def.sounds.fall, {pos = pos})
157+
core.sound_play(def.sounds.fall, {pos = pos}, true)
158158
end
159159

160160
obj:get_luaentity():set_node(node, metatable)
@@ -187,7 +187,7 @@ local function drop_attached_node(p)
187187
def.preserve_metadata(pos_copy, node_copy, oldmeta, drops)
188188
end
189189
if def and def.sounds and def.sounds.fall then
190-
core.sound_play(def.sounds.fall, {pos = p})
190+
core.sound_play(def.sounds.fall, {pos = p}, true)
191191
end
192192
core.remove_node(p)
193193
for _, item in pairs(drops) do

Diff for: ‎builtin/game/item.lua

+8-2
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,10 @@ function core.do_item_eat(hp_change, replace_with_item, itemstack, user, pointed
475475
user:set_hp(user:get_hp() + hp_change)
476476

477477
if def and def.sound and def.sound.eat then
478-
minetest.sound_play(def.sound.eat, { pos = user:get_pos(), max_hear_distance = 16 })
478+
core.sound_play(def.sound.eat, {
479+
pos = user:get_pos(),
480+
max_hear_distance = 16
481+
}, true)
479482
end
480483

481484
if replace_with_item then
@@ -582,7 +585,10 @@ function core.node_dig(pos, node, digger)
582585
if not core.settings:get_bool("creative_mode") then
583586
wielded:add_wear(dp.wear)
584587
if wielded:get_count() == 0 and wdef.sound and wdef.sound.breaks then
585-
core.sound_play(wdef.sound.breaks, {pos = pos, gain = 0.5})
588+
core.sound_play(wdef.sound.breaks, {
589+
pos = pos,
590+
gain = 0.5
591+
}, true)
586592
end
587593
end
588594
end

0 commit comments

Comments
 (0)
Please sign in to comment.