Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager: 1.22.4 -> 1.22.6 #78997

Merged
merged 2 commits into from Feb 2, 2020
Merged

networkmanager: 1.22.4 -> 1.22.6 #78997

merged 2 commits into from Feb 2, 2020

Conversation

worldofpeace
Copy link
Contributor

  • also delete unused hardcode-gsettings patch

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/1.22.6/NEWS

Motivation for this change
Things done

Built on master.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added this to the 20.03 milestone Feb 1, 2020
@worldofpeace worldofpeace added this to WIP in Staging via automation Feb 1, 2020
@worldofpeace worldofpeace moved this from WIP to Needs review in Staging Feb 1, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Feb 1, 2020

The patch is for network-manager-applet.

@worldofpeace
Copy link
Contributor Author

The patch is for network-manager-applet.

How funny I forget when I actually wrote the patch 🤣
I forced pushed to reorganize the directory.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Feb 1, 2020 •
edited

Now that I think of it, I don't need that hardcode patch anymore for wingpanel and switchboard,

Staging automation moved this from Needs review to Ready Feb 1, 2020
jtojnar
jtojnar approved these changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 1, 2020

IMHO they still make sense for other uses.

Also we should start thinking where we will place libnma.

@worldofpeace worldofpeace merged commit 50ac34e into NixOS:staging Feb 2, 2020
Staging automation moved this from Ready to Done Feb 2, 2020
@worldofpeace worldofpeace deleted the nm-1.22.6 branch February 2, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@Phreedom Phreedom Awaiting requested review from Phreedom

@jensbin jensbin Awaiting requested review from jensbin

@domenkozar domenkozar Awaiting requested review from domenkozar

@obadz obadz Awaiting requested review from obadz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
Staging
  
Done
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar