Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdlib: 1.5.0 -> 1.6.0 #79005

Merged
merged 1 commit into from Feb 11, 2020
Merged

tdlib: 1.5.0 -> 1.6.0 #79005

merged 1 commit into from Feb 11, 2020

Conversation

SeTSeR
Copy link
Contributor

@SeTSeR SeTSeR commented Feb 1, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vyorkin February 1, 2020 11:27
vyorkin
vyorkin approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@vyorkin vyorkin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tested on my machine)

@vyorkin
Copy link
Member

vyorkin commented Feb 9, 2020

@GrahamcOfBorg build tdlib

@JohnAZoidberg JohnAZoidberg merged commit f528d88 into NixOS:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyorkin vyorkin vyorkin approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SeTSeR @vyorkin @JohnAZoidberg