Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages-explorer to use relative paths. #329

Merged
merged 1 commit into from Mar 6, 2020

Conversation

egasimus
Copy link
Contributor

@egasimus egasimus commented Mar 2, 2020

To save some seconds when doing the occasional lookup, I self-host a mirror of the NixOS packages and options pages. When serving from a subfolder, e.g. http://localhost/nixos-homepage/nixos/packages.html, the usage of absolute paths trips up the data fetching. Changing the paths to relative fixes that.

To save some seconds when doing the occasional lookup, I self-host a mirror of the NixOS `packages` and `options` pages. When serving from a subfolder, e.g. `http://localhost/nixos-homepage/nixos/packages.html`, the usage of absolute paths trips up the data fetching. Changing the paths to relative fixes that.
@samueldr
Copy link
Member

samueldr commented Mar 5, 2020

Thanks for the improvement!

@garbas garbas self-requested a review March 6, 2020 10:22
Copy link
Member

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thx!

@garbas garbas merged commit 1f86c43 into NixOS:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants