Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.switcher: init at 26 #81522

Closed
wants to merge 1 commit into from

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Mar 2, 2020

Motivation for this change

This is a nice extension for quickly finding a window among gazillions of other windows.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for packaging this; I can remove the inlined expression from my configuration ^^

My derivation tracked an unstable-YYYY-MM-DD git version, but it looks like releases are frequent enough that that shouldn't be necessary.

@GrahamcOfBorg build gnomeExtensions.switcher


uuid = "switcher@landau.fi";

nativeBuildInputs = [ glib ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used for anything? The git repo comes with compiled schemas, so there's no need for glib-compile-schemas at least.


stdenv.mkDerivation rec {
pname = "gnome-shell-switcher";
version = "26";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream have released 28 which supports gnome-shell 3.36.

@danieldk danieldk closed this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants