Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.fruzzy: init at 2019-10-28 #81440

Merged
merged 1 commit into from May 27, 2020
Merged

vimPlugins.fruzzy: init at 2019-10-28 #81440

merged 1 commit into from May 27, 2020

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Mar 1, 2020

Motivation for this change

This adds the vim plugin fruzzy. Note that this plugin has a 'native' component (fuzzy searcher implemented in Nim), so I bootstrapped the Nim dependencies in a little bit of a hackey way (could be made neater if #67878 ever gets merged).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NickHu NickHu requested a review from jonringer as a code owner March 1, 2020 14:09
@NickHu
Copy link
Contributor Author

NickHu commented Mar 1, 2020

@GrahamcOfBorg build vimPlugins.fruzzy

@ofborg ofborg bot added the 6.topic: vim label Mar 1, 2020
@NickHu
Copy link
Contributor Author

NickHu commented Mar 4, 2020

rebased and resolved 'forbidden in restricted mode'
@GrahamcOfBorg build vimPlugins.fruzzy

@NickHu
Copy link
Contributor Author

NickHu commented May 17, 2020

@jonringer Have been using this happily for months now, is anything blocking merge? Thanks!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/167

@Mic92
Copy link
Member

Mic92 commented May 27, 2020

Result of nixpkgs-review pr 81440 1

1 package built:
- vimPlugins.fruzzy

@Mic92 Mic92 merged commit f17888b into NixOS:master May 27, 2020
@jonringer
Copy link
Contributor

I took a break while my server was being repaired. sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@timokau timokau Awaiting requested review from timokau

@Mic92 Mic92 Awaiting requested review from Mic92

@kalbasit kalbasit Awaiting requested review from kalbasit

@jorsn jorsn Awaiting requested review from jorsn

@vcunat vcunat Awaiting requested review from vcunat

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NickHu @nixos-discourse @Mic92 @jonringer