Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-easytags: Fix to work with universal-ctags (which is in nixpkgs) #81458

Merged
merged 1 commit into from Mar 2, 2020

Conversation

KoviRobi
Copy link
Contributor

@KoviRobi KoviRobi commented Mar 1, 2020

Motivation for this change
Things done

Tested with both universal-ctags and exuberant ctags, both seem to work. Currently only exuberant ctags works.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

looks like upstream is.... not very active

[3 built, 2 copied (0.3 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81458
1 package built:
vimPlugins.vim-easytags

@jonringer
Copy link
Contributor

@GrahamcOfBorg build vimPlugins.vim-easytags

@jonringer jonringer merged commit 2e6b7b0 into NixOS:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants