Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] amp: 0.6.1 -> 0.6.2 #81463

Merged
merged 1 commit into from Mar 10, 2020
Merged

[20.03] amp: 0.6.1 -> 0.6.2 #81463

merged 1 commit into from Mar 10, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Mar 1, 2020

Motivation for this change

Fix hydra build.

Backport: #81462
ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@B4dM4n
amp: 0.6.1 -> 0.6.2
f0608b0 
(cherry picked from commit 1820ce4)
@ofborg ofborg bot requested a review from sbourdeauducq March 1, 2020 20:59
@bhipple
Copy link
Contributor

bhipple commented Mar 9, 2020

We merged to master in #82021, which has the same diff as the original commit this is referencing.

CC @marsam @NixOS/backports can we merge this to 20.03 for ZHF?

@marsam marsam merged commit c5db275 into NixOS:release-20.03 Mar 10, 2020
@B4dM4n B4dM4n deleted the amp-update-backport branch March 10, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@sbourdeauducq sbourdeauducq Awaiting requested review from sbourdeauducq

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @bhipple @marsam