Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp: 0.6.1 -> 0.6.2 #81462

Closed
wants to merge 1 commit into from
Closed

amp: 0.6.1 -> 0.6.2 #81462

wants to merge 1 commit into from

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Mar 1, 2020

Motivation for this change

Fix hydra build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@B4dM4n B4dM4n mentioned this pull request Mar 1, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from sbourdeauducq March 1, 2020 20:50
@bhipple
Copy link
Contributor

bhipple commented Mar 9, 2020

Apologies @B4dM4n, I didn't see your PR and opened another PR with an identical diff, which has now been merged, so this PR should be closed:
#82021

@B4dM4n B4dM4n closed this Mar 10, 2020
@B4dM4n B4dM4n deleted the amp-update branch March 10, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbourdeauducq sbourdeauducq Awaiting requested review from sbourdeauducq

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @bhipple