Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.nixfmt: Unbreak #81504

Merged
merged 1 commit into from Mar 2, 2020
Merged

haskellPackages.nixfmt: Unbreak #81504

merged 1 commit into from Mar 2, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Mar 2, 2020

Motivation for this change

Unbreak nixfmt, which needs some upper version bounds relaxed (NixOS/nixfmt#62).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
haskellPackages.nixfmt: Unbreak
11454b2 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk changed the title haskellPackage.nixfmt: Unbreak haskellPackages.nixfmt: Unbreak Mar 2, 2020
@cdepillabout
Copy link
Member

Looks like this works, thanks!

@cdepillabout cdepillabout merged commit df31297 into NixOS:haskell-updates Mar 2, 2020
@andersk andersk deleted the nixfmt branch December 26, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andersk @cdepillabout