Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] nixos/acme: backport #81369 and #81371 #81435

Merged
merged 2 commits into from Mar 7, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Mar 1, 2020

Motivation for this change

The issues addressed are also valid for 20.03. Backports #81369 and #81371.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also separate directory and file permissions so the certificate files
don't end up with the executable bit.

Fixes NixOS#81335

(cherry picked from commit 3575555)
@infinisil
Copy link
Member

@GrahamcOfBorg test acme

@infinisil infinisil merged commit 883217d into NixOS:release-20.03 Mar 7, 2020
@mweinelt mweinelt deleted the pr/20.03/acme branch March 7, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants