Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.monosat: Fix Python 3.8 build #81562

Merged
merged 1 commit into from Mar 3, 2020
Merged

python3Packages.monosat: Fix Python 3.8 build #81562

merged 1 commit into from Mar 3, 2020

Conversation

acairncross
Copy link
Contributor

@acairncross acairncross commented Mar 2, 2020 •
edited

Motivation for this change

Package was broken because time.clock was removed in Python 3.8.
ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit 2148a15 into NixOS:master Mar 3, 2020
@acairncross
Copy link
Contributor Author

Oh dear, the fetchpatch failed (wrong sha256) so it broke the builds: https://hydra.nixos.org/eval/1573587!

The way I had it building locally was that I ran nix-prefetch-url on the patch URL and used the hash produced by that. But this hash disagrees with the hash fetchpatch expects, so was this the wrong thing to do/is this expected behaviour?

@andir
Copy link
Member

andir commented Mar 3, 2020

Yes, if your local Nix store already has the correct content addressed path it will not bother to fetch/validate it.

The problem here with fetchpatch is that patches are post-processed ("normalized") causing the hash to be different from the raw patch hash. This is often required as some repositories add a git version line and other tiny differences to their patches. Those obviously do not matter to the content so the hash we care about (here) is the hash after post-processing.

Can you (@acairncross) open a PR with the right hash? I was just about to do so myself. The correct hash that I am seeing corresponds to the hash that hydra sees: 1p2y0jw8hb9c90nbffhn86k1dxd6f6hk5v70dfmpzka3y6g1ksal

@acairncross acairncross deleted the monosat-py38 branch March 3, 2020 17:49
acairncross added a commit to acairncross/nixpkgs that referenced this pull request Mar 3, 2020
@acairncross
python3Packages.monosat: Fix hash
aa7fced 
PR NixOS#81562 inadvertently broke these builds
@acairncross acairncross mentioned this pull request Mar 3, 2020
Merged
10 tasks
@jonringer jonringer mentioned this pull request Mar 3, 2020
Closed
10 tasks
jonringer pushed a commit that referenced this pull request Mar 3, 2020
@acairncross @jonringer
python3Packages.monosat: Fix hash
3db82f6 
PR #81562 inadvertently broke these builds
@acairncross acairncross mentioned this pull request Mar 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acairncross @andir @FRidh