Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #79750 from doronbehar/update-luarocks" #81483

Merged
merged 1 commit into from Mar 2, 2020
Merged

Revert "Merge pull request #79750 from doronbehar/update-luarocks" #81483

merged 1 commit into from Mar 2, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

This reverts commit 0566b5c, reversing changes made to 4d6e3bf.

This fixes neovim et al while #80528 isn't resolved.

cc. @teto @doronbehar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault lovesegfault mentioned this pull request Mar 2, 2020
Closed
10 tasks
@ofborg ofborg bot requested review from teto and 7c6f434c March 2, 2020 02:52
cole-h
cole-h approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been running this locally for a while. Lets me build my config that includes neovim without errors, which is a major plus. Not ideal, but a necessary stopgap, IMHO.

@doronbehar
Copy link
Contributor

I should have ran nix-review before merging 3.2.1 -> 3.3.1...

@7c6f434c 7c6f434c merged commit ca7f750 into NixOS:master Mar 2, 2020
@7c6f434c
Copy link
Member

7c6f434c commented Mar 2, 2020

OK, let's unbreak NeoVim

@vcunat vcunat mentioned this pull request Mar 2, 2020
Closed
@lovesegfault lovesegfault deleted the fix-neovim branch April 7, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@cole-h cole-h cole-h approved these changes

@teto teto Awaiting requested review from teto

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lovesegfault @doronbehar @7c6f434c @cole-h