New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dell/xps/13-7390: fix screen corruption issues #148
Conversation
Is this patch upstream or was reviewed? We could also integrate this patch directly in nixpkgs if it does not regress on other hardware. |
On 01:22 03.03.20, Jörg Thalheim wrote:
Is this patch upstream or was reviewed? We could also integrate this
patch directly upstream if it does not regress on other hardware.
I searched through my mail archives but wasn't able to find that mail.
According to the bug entry it wasn't upstreamed yet due to missing
feedback: https://bugs.freedesktop.org/show_bug.cgi?id=110511#c32
The conversation continued over at
https://gitlab.freedesktop.org/drm/intel/issues/272 but wasn't resolved
from what I can say.
I also have a 9380 that is supposed to have flickering but I can't
really reproduce the effects seen there on my hardware. I occasionally
have a very short flickering of the screen. It feels like just a single
black frame.
If that fixes it for you then it might be worth responding to the linked
GitLab issue. If they aren't receptible of that we can just try to
submit that to the upstream kernel via their ML?
|
It looks like I didn't have much to add, so I left a comment pointing a fellow 7390 user to the patch I'm using.
You mean the Linux kernel? That sounds awesome, and I'm definitely interested (even though I'd be submitting someone else's patch (under their name ofc)). However, I have zero experience submitting patches to the Linux kernel. Do you have recommendations for how to move forward? I'm also open to putting this patch in Nixpkgs then waiting for freedesktop to figure things out (but it seems like that would take a while).
|
This issue might have been fixed by https://gitlab.freedesktop.org/drm/intel/issues/272#note_433464 |
I've updated to the latest 5.6 kernel in Nixpkgs. I can confirm that the screen issues are better than before, but I still get an occasional screen-full of random colors, something that never happened with the kernel patch above |
Can it be guarded with a falsy option? |
What does it mean for something to be guarded with a falsy option?
|
Something along these lines. |
Oh, yeah, that would make sense. I think the primary goal is to make sure that XPS 7390 users at least know a patch exists. That option and/or this PR serve as documentation for the fix. Do you think I should add the above option to the PR or simply closing this PR, allowing users to copy-paste the fix themselves when they find this PR via a search engine? |
I think you should add that option, and documented in a/the README somewhere and merge it down. it’s better for people to look/find documentation rather than deal with patches. |
This was fixed in kernel later on. |
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855608
With this patch, the XPS 13 (7390)'s screen no longer randomly glitches (very noticeable, sometimes tough to undo and sometimes obstructing text). I've been using this patch for the past couple months on my XPS 13 (7390) and it has fixed the issue entirely.
On the other hand, this patch leads to the the Linux kernel being rebuild manually, so even though I think this code is good to document, I don't know if it should be merged.