Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dell/xps/13-7390: fix screen corruption issues #148

Closed

Conversation

aaronjanse
Copy link
Member

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1855608

With this patch, the XPS 13 (7390)'s screen no longer randomly glitches (very noticeable, sometimes tough to undo and sometimes obstructing text). I've been using this patch for the past couple months on my XPS 13 (7390) and it has fixed the issue entirely.

On the other hand, this patch leads to the the Linux kernel being rebuild manually, so even though I think this code is good to document, I don't know if it should be merged.

@Mic92
Copy link
Member

Mic92 commented Mar 3, 2020

Is this patch upstream or was reviewed? We could also integrate this patch directly in nixpkgs if it does not regress on other hardware.

@andir
Copy link
Member

andir commented Mar 3, 2020 via email

@aaronjanse
Copy link
Member Author

If that fixes it for you then it might be worth responding to the linked GitLab issue. If they aren't receptible of that we can just try to submit that to the upstream kernel via their ML?

It looks like I didn't have much to add, so I left a comment pointing a fellow 7390 user to the patch I'm using.

If they aren't receptible of that we can just try to submit that to the upstream kernel via their ML?

You mean the Linux kernel? That sounds awesome, and I'm definitely interested (even though I'd be submitting someone else's patch (under their name ofc)). However, I have zero experience submitting patches to the Linux kernel.

Do you have recommendations for how to move forward? I'm also open to putting this patch in Nixpkgs then waiting for freedesktop to figure things out (but it seems like that would take a while).

if it does not regress on other hardware
I don't have much extra hardware to test on :-/

@Mic92
Copy link
Member

Mic92 commented Mar 11, 2020

This issue might have been fixed by https://gitlab.freedesktop.org/drm/intel/issues/272#note_433464
in linux kernel version newer than 5.6rcX

@aaronjanse
Copy link
Member Author

I've updated to the latest 5.6 kernel in Nixpkgs. I can confirm that the screen issues are better than before, but I still get an occasional screen-full of random colors, something that never happened with the kernel patch above

@kalbasit
Copy link
Member

kalbasit commented May 2, 2020

Can it be guarded with a falsy option?

@aaronjanse
Copy link
Member Author

aaronjanse commented May 2, 2020 via email

@kalbasit
Copy link
Member

kalbasit commented May 2, 2020

What does it mean for something to be guarded with a falsy option?

options.nixos-hardware.fix-xps-13-issue.enable = mkEnableOption "fix... ";

config = mkIf (config.nixos-hardware.fix-xps-13-issue.enable) {
...
};

Something along these lines.

@aaronjanse
Copy link
Member Author

Oh, yeah, that would make sense. I think the primary goal is to make sure that XPS 7390 users at least know a patch exists. That option and/or this PR serve as documentation for the fix.

Do you think I should add the above option to the PR or simply closing this PR, allowing users to copy-paste the fix themselves when they find this PR via a search engine?

@kalbasit
Copy link
Member

kalbasit commented May 3, 2020

I think you should add that option, and documented in a/the README somewhere and merge it down. it’s better for people to look/find documentation rather than deal with patches.

@domenkozar
Copy link
Member

This was fixed in kernel later on.

@domenkozar domenkozar closed this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants