Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops
base: 9d31b92aac5d^
Choose a base ref
...
head repository: NixOS/nixops
compare: d0ec9ef9b21d
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 2, 2020

  1. parallel.py

    @doshitan @grahamc
    doshitan authored and grahamc committed Mar 2, 2020
    Copy the full SHA
    9d31b92 View commit details
    Browse the repository at this point in the history

  2. parallel: run_tasks -> List[Result], not List[Optional[Result]] 

    If any of the tasks raised an exception, we don't return any results.
In the first typing of this function, I saw we were adding None to
the results even if there was an exception. This was just to see
if we were done collecting or not. Changing this to a counter fixes it
and removes the Optional in the return.
    @grahamc
    grahamc committed Mar 2, 2020
    Copy the full SHA
    7ff5b72 View commit details
    Browse the repository at this point in the history

  3. statefile: partial application of doshitan's PR#1238

    @grahamc
    grahamc committed Mar 2, 2020
    Copy the full SHA
    d0ec9ef View commit details
    Browse the repository at this point in the history