-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/polybar: init #81510
nixos/polybar: init #81510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea for making defaults work. Thanks, LGTM!
Since we're adding a polybar module to nixpkgs, would we want to merge some of home-manager's polybar code? |
@aaronjanse probably? I don't use home-manager but the more I think about, its must be more of a home-manager problem than a nixos problem. Is time better spent on improving home-manager rather than expanding |
I personally would like to see as much as home-manager as nixpkgs as possible. Otherwise, external modules have to juggle duplicated options between home-manager and nixpkgs, which could get ugly. |
I can't parse that sentence |
Oops, I forgot a few words! In other words, if something in home-manager can be merged into nixpkgs, I would personally want it to be merged ;-) |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/why-isnt-more-of-home-manager-merged-into-nixpkgs/6096/5 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/why-isnt-more-of-home-manager-merged-into-nixpkgs/6096/6 |
To be honest, this looks too trivial for a module to include in nixpkgs. It doesn't do anything except add a font to the system fonts. Is that even necessary in all cases? If I use another font for my polybar, I won't need the siji font, will I? Of course you need the fonts that you use in configs. |
I'm closing this issue, as polybar support belongs in something like home-manager. |
I simple solution could be to just add documentation for using the polybar package. I believe there's a section for that in the nixpkgs manual. |
Motivation for this change
It is a bit difficult to get polybar working. It looks strange when a font is missing, and might be missing compile-time support for some use-cases. Adding a NixOS module takes care of the font and makes package configuration more discoverable to the user.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Polybar maintainers: @afldcr @filalex77