Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CPAN: fix build, patch url content has changed #81480

Closed
wants to merge 1 commit into from
Closed

perlPackages.CPAN: fix build, patch url content has changed #81480

wants to merge 1 commit into from

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Mar 2, 2020 •
edited

ZHF: #80379

The LoadBlessed patch in #80471 was included from a GitHub PR without a commit reference, and the contents have changed.

Updated the patch from the merged PR, and stored as a file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
perlPackages.CPAN: fix build, patch url content was changed
558bc8a 
The LoadBlessed patch in PR 80471 was included from a GitHub PR
without a commit reference, and the contents have changed.

Updated the patch from the merged PR, and stored as a file.
@veprbl veprbl closed this in fa73723 Mar 27, 2020
veprbl added a commit that referenced this pull request Mar 27, 2020
@veprbl
perlPackages.CPAN: fix patch download
5ffc821 
Fixes: 153b0db ('perlPackages.CPAN: apply patch to fix changed YAML module default')
Closes: #81480
(cherry picked from commit fa73723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@stigtsp