Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry: 1.0.3 -> 1.0.5 #81536

Merged
merged 2 commits into from Mar 2, 2020
Merged

poetry: 1.0.3 -> 1.0.5 #81536

merged 2 commits into from Mar 2, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Mar 2, 2020 •
edited

Motivation for this change

Also bumped poetry2nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jbaum98 March 2, 2020 16:53
@jonringer jonringer mentioned this pull request Mar 2, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81536
3 package built:
poetry python37Packages.aria2p python38Packages.aria2p

@jonringer jonringer merged commit 298b50d into NixOS:master Mar 2, 2020
@adisbladis
Copy link
Member Author

@jonringer poetry (top-level) updates does not touch pythonPackages at all.

@jonringer
Copy link
Contributor

I know :). aria2p imports "poetry", so it needs to consume as a package. the format = "pyproject"; will use the executable from pkgs

@jonringer
Copy link
Contributor

really what was happening was that a single interpreter version was being passed to both, which is also not what we want.

@domenkozar domenkozar mentioned this pull request Mar 20, 2020
Merged
10 tasks
@domenkozar
Copy link
Member

Missed #82990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @jonringer @domenkozar