Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdal: 3.0.3 -> 3.0.4 #81537

Merged
merged 1 commit into from Mar 9, 2020
Merged

gdal: 3.0.3 -> 3.0.4 #81537

merged 1 commit into from Mar 9, 2020

Conversation

tollb
Copy link
Contributor

@tollb tollb commented Mar 2, 2020

Update GDAL/OGR to 3.0.4

GDAL 3.0.4 includes a fix for build failure due to poppler 0.85.0
upgrade (change to parameters for setErrorCallback). See commit:

OSGeo/gdal@6e9e51e

Motivation for this change

Address build failure on hydra:

https://hydra.nixos.org/build/113479800

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Update GDAL/OGR to 3.0.4

GDAL 3.0.4 includes a fix for build failure due to poppler 0.85.0
upgrade (change to parameters for setErrorCallback). See commit:

OSGeo/gdal@6e9e51e
@tollb
Copy link
Contributor Author

tollb commented Mar 2, 2020

@brano543 @das-g

@brano543
Copy link
Contributor

brano543 commented Mar 2, 2020

Seems fine to me.

@das-g
Copy link
Member

das-g commented Mar 3, 2020

I've run LC_ALL=C.utf-8 nix run nixpkgs.nixpkgs-review -c nixpkgs-review pr 81537

Full output (click to expand)
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/81537/head:refs/nixpkgs-review/1
remote: Enumerating objects: 61, done.
remote: Counting objects: 100% (61/61), done.
remote: Compressing objects: 100% (23/23), done.
remote: Total 73 (delta 46), reused 38 (delta 36), pack-reused 12
Unpacking objects: 100% (73/73), done.
From https://github.com/NixOS/nixpkgs
   b07eb540480..c37b4466c0f  master     -> refs/nixpkgs-review/0
$ git worktree add /home/das-g/.cache/nixpkgs-review/pr-81537-1/nixpkgs c37b4466c0fca907ba2d62a2e7c85402aa8f4800
Preparing worktree (detached HEAD c37b4466c0f)
Updating files: 100% (21105/21105), done.
HEAD is now at c37b4466c0f python27Packages.authlib: 0.13 -> 0.14.1
$ git merge --no-commit bb46f897d1396768cec5d42a57b7fe17574c4369
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/das-g/.cache/nixpkgs-review/pr-81537-1/build.nix
builder for '/nix/store/bwcab06019zm2sk7xl189zhsl7diczq0-mysql-workbench-8.0.15.drv' failed with exit code 1; last 10 log lines:
  In file included from /nix/store/3lvdz4g4jvpyhxakxiai30z43j835via-glib-2.62.5-dev/include/glib-2.0/glib/galloca.h:32,
                   from /nix/store/3lvdz4g4jvpyhxakxiai30z43j835via-glib-2.62.5-dev/include/glib-2.0/glib.h:30,
                   from ../library/base/base/log.h:78,
                   from ../frontend/linux/linux_utilities/widget_saver.cpp:24:
  /nix/store/3lvdz4g4jvpyhxakxiai30z43j835via-glib-2.62.5-dev/include/glib-2.0/glib/gtypes.h:549:26: note: declared here
    549 | typedef struct _GTimeVal GTimeVal GLIB_DEPRECATED_TYPE_IN_2_62_FOR(GDateTime);
        |                          ^~~~~~~~
  cc1plus: all warnings being treated as errors
  [28/781] Building CXX object ext/scintilla/gtk/CMakeFiles/wbscintilla.dir/__/src/Document.cxx.o
  ninja: build stopped: subcommand failed.
builder for '/nix/store/0wwfszv3mv1j6clwd1jd4d39gy011am9-python3.8-python-mapnik-3.0.16.drv' failed with exit code 1; last 10 log lines:
  /nix/store/b7ksh1j0assq73sz3kxnzf2vd0s8zmym-mapnik-3.0.23/include/mapnik/path.hpp:109:8: error: use of deleted function ‘mapnik::util::non_copyable_::noncopyable::noncopyable(const mapnik::util::non_copyable_::noncopyable&)’
  In file included from /nix/store/b7ksh1j0assq73sz3kxnzf2vd0s8zmym-mapnik-3.0.23/include/mapnik/proj_transform.hpp:28,
                   from /nix/store/b7ksh1j0assq73sz3kxnzf2vd0s8zmym-mapnik-3.0.23/include/mapnik/view_transform.hpp:29,
                   from /nix/store/b7ksh1j0assq73sz3kxnzf2vd0s8zmym-mapnik-3.0.23/include/mapnik/svg/geometry_svg_generator.hpp:31,
                   from /nix/store/b7ksh1j0assq73sz3kxnzf2vd0s8zmym-mapnik-3.0.23/include/mapnik/svg/geometry_svg_generator_impl.hpp:25,
                   from src/mapnik_svg_generator_grammar.cpp:23:
  /nix/store/b7ksh1j0assq73sz3kxnzf2vd0s8zmym-mapnik-3.0.23/include/mapnik/util/noncopyable.hpp:45:5: note: declared here
     45 |     noncopyable( noncopyable const& ) = delete;
        |     ^~~~~~~~~~~
  error: command 'gcc' failed with exit status 1
builder for '/nix/store/azmxs0zywm6w0qiwcy94jm91nfvbmw5l-python3.7-python-mapnik-3.0.16.drv' failed with exit code 1; last 10 log lines:
  /nix/store/zbmhbj869fk352j0fa5c72fsg3jspjiw-mapnik-3.0.23/include/mapnik/path.hpp:109:8: error: use of deleted function ‘mapnik::util::non_copyable_::noncopyable::noncopyable(const mapnik::util::non_copyable_::noncopyable&)’
  In file included from /nix/store/zbmhbj869fk352j0fa5c72fsg3jspjiw-mapnik-3.0.23/include/mapnik/proj_transform.hpp:28,
                   from /nix/store/zbmhbj869fk352j0fa5c72fsg3jspjiw-mapnik-3.0.23/include/mapnik/view_transform.hpp:29,
                   from /nix/store/zbmhbj869fk352j0fa5c72fsg3jspjiw-mapnik-3.0.23/include/mapnik/svg/geometry_svg_generator.hpp:31,
                   from /nix/store/zbmhbj869fk352j0fa5c72fsg3jspjiw-mapnik-3.0.23/include/mapnik/svg/geometry_svg_generator_impl.hpp:25,
                   from src/mapnik_svg_generator_grammar.cpp:23:
  /nix/store/zbmhbj869fk352j0fa5c72fsg3jspjiw-mapnik-3.0.23/include/mapnik/util/noncopyable.hpp:45:5: note: declared here
     45 |     noncopyable( noncopyable const& ) = delete;
        |     ^~~~~~~~~~~
  error: command 'gcc' failed with exit status 1
builder for '/nix/store/jnam23k4w2fq26fkg1vnbgh66faai9mn-python2.7-python-mapnik-3.0.16.drv' failed with exit code 1; last 10 log lines:
  /nix/store/3rx1d2f1avv8xdw84iw94sany7nf3hk1-mapnik-3.0.23/include/mapnik/path.hpp:109:8: error: use of deleted function ‘mapnik::util::non_copyable_::noncopyable::noncopyable(const mapnik::util::non_copyable_::noncopyable&)’
  In file included from /nix/store/3rx1d2f1avv8xdw84iw94sany7nf3hk1-mapnik-3.0.23/include/mapnik/proj_transform.hpp:28,
                   from /nix/store/3rx1d2f1avv8xdw84iw94sany7nf3hk1-mapnik-3.0.23/include/mapnik/view_transform.hpp:29,
                   from /nix/store/3rx1d2f1avv8xdw84iw94sany7nf3hk1-mapnik-3.0.23/include/mapnik/svg/geometry_svg_generator.hpp:31,
                   from /nix/store/3rx1d2f1avv8xdw84iw94sany7nf3hk1-mapnik-3.0.23/include/mapnik/svg/geometry_svg_generator_impl.hpp:25,
                   from src/mapnik_svg_generator_grammar.cpp:23:
  /nix/store/3rx1d2f1avv8xdw84iw94sany7nf3hk1-mapnik-3.0.23/include/mapnik/util/noncopyable.hpp:45:5: note: declared here
     45 |     noncopyable( noncopyable const& ) = delete;
        |     ^~~~~~~~~~~
  error: command 'gcc' failed with exit status 1
cannot build derivation '/nix/store/z54667vfwirg6ll10q9xkbfbij5wnjmz-python2.7-tilestache-1.51.14.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mpvmidh853wsh1lhayhf5cswc3jn0xvw-env.drv': 5 dependencies couldn't be built
[2 built (4 failed), 0.0 MiB DL]
error: build of '/nix/store/mpvmidh853wsh1lhayhf5cswc3jn0xvw-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/81537
7 package marked as broken and skipped:
gazebo gazebo-headless gazeboSimulator.gazebo6 gazeboSimulator.gazebo6-headless gazeboSimulator.gazebo7 gazeboSimulator.gazebo7-headless openspace

5 package failed to build:
mysql-workbench python27Packages.python-mapnik python27Packages.tilestache python37Packages.python-mapnik python38Packages.python-mapnik

23 package built:
gdal grass libLAS mapnik mapproxy merkaartor openorienteering-mapper perl528Packages.Tirex perl530Packages.Tirex postgresqlPackages.postgis python27Packages.cartopy python27Packages.gdal python27Packages.worldengine python37Packages.cartopy worldengine-cli python38Packages.cartopy python38Packages.gdal python38Packages.worldengine qgis qgis-unwrapped qlandkartegt qmapshack saga

[0.0 MiB DL]
error: build log of '/nix/store/z54667vfwirg6ll10q9xkbfbij5wnjmz-python2.7-tilestache-1.51.14.drv' is not available
$ nix-shell /home/das-g/.cache/nixpkgs-review/pr-81537-1/shell.nix
these paths will be fetched (0.51 MiB download, 2.47 MiB unpacked):
  /nix/store/6wf86wppdpy6hwlv9c7dickvs547n2bv-bash-interactive-4.4-p23-dev
  /nix/store/apah3qkxv6s05rj3rvlliw7gjdfwmi1a-bash-interactive-4.4-p23-doc
  /nix/store/cqdbhg2xv6mql8j80ybk05cz3m9fgi4b-bash-interactive-4.4-p23-man
  /nix/store/g4n1li9q6cg70mg81xlrhb1z4rcrs7ba-bash-interactive-4.4-p23-info
copying path '/nix/store/apah3qkxv6s05rj3rvlliw7gjdfwmi1a-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/g4n1li9q6cg70mg81xlrhb1z4rcrs7ba-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/cqdbhg2xv6mql8j80ybk05cz3m9fgi4b-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
copying path '/nix/store/6wf86wppdpy6hwlv9c7dickvs547n2bv-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
Summary:

7 package marked as broken and skipped:

  • gazebo
  • gazebo-headless
  • gazeboSimulator.gazebo6
  • gazeboSimulator.gazebo6-headless
  • gazeboSimulator.gazebo7
  • gazeboSimulator.gazebo7-headless
  • openspace

5 package failed to build:

  • mysql-workbench
  • python27Packages.python-mapnik
  • python27Packages.tilestache
  • python37Packages.python-mapnik
  • python38Packages.python-mapnik

23 package built:

  • gdal
  • grass
  • libLAS
  • mapnik
  • mapproxy
  • merkaartor
  • openorienteering-mapper
  • perl528Packages.Tirex
  • perl530Packages.Tirex
  • postgresqlPackages.postgis
  • python27Packages.cartopy
  • python27Packages.gdal
  • python27Packages.worldengine
  • python37Packages.cartopy
  • worldengine-cli
  • python38Packages.cartopy
  • python38Packages.gdal
  • python38Packages.worldengine
  • qgis
  • qgis-unwrapped
  • qlandkartegt
  • qmapshack
  • saga

@tollb
Copy link
Contributor Author

tollb commented Mar 3, 2020

@das-g Thanks for following-up and providing the nixpkgs-review output.

I was aware of the python-mapnik issue which I believe is due to a recent update to mapnik version 3.0.23. I was planning to file a separate PR for python-mapnik which incorporates upstream commits, including the one that addresses the build issue with mapnik 3.0.23. I believe that update should also address the python27Packages.tilestache issue.

As for mysql-workbench, it appears that build has been failing for unrelated reasons for a while:
https://hydra.nixos.org/build/113768418

Any suggestions before moving forward on this PR? Should I file the second PR for python-mapnik with a recommendation that this one should be merged first?

@marsam marsam merged commit 9760d23 into NixOS:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants